QVM - require gate_times_ns argument in noise_properties_from_calibration #7644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The default value for the `gate_times_ns` argument of `noise_properties_from_calibration` was deprecated in quantumlib#7399. Here we make the argument mandatory. Note the literal "legacy" value, i.e., `gate_times_ns="legacy"`, can be used as a stand-in for the old default. Related to b/395705720
pavoljuhas
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7644 +/- ##
==========================================
- Coverage 99.56% 99.37% -0.20%
==========================================
Files 1088 1078 -10
Lines 96083 96054 -29
==========================================
- Hits 95667 95451 -216
- Misses 416 603 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the
gate_times_nsargument ofnoise_properties_from_calibrationwas deprecated in #7399.Here we make the argument mandatory.
Note the literal "legacy" value, i.e.,
gate_times_ns="legacy",can be used as a stand-in for the old default.
Related to b/395705720